Skip to content

Commit

Permalink
Merge #136688
Browse files Browse the repository at this point in the history
136688: roachtest: deflake activerecord test r=fqazi a=fqazi

Previously, the active record test had a test flake on CockroachDB::FixturesTest#test_create_fixtures. This patch adds that test on the ignore list.

Fixes: #136460

Release note: None

Co-authored-by: Faizan Qazi <[email protected]>
  • Loading branch information
craig[bot] and fqazi committed Dec 5, 2024
2 parents f9a6082 + e1b99f8 commit 6f2b16c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/cmd/roachtest/tests/activerecord_blocklist.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ var activeRecordBlocklist = blocklist{
var activeRecordIgnoreList = blocklist{
`ActiveRecord::ConnectionAdapters::PostgreSQLAdapterTest#test_translate_no_connection_exception_to_not_established`: "pg_terminate_backend not implemented",
`BasicsTest#test_default_values_are_deeply_dupped`: "flaky",
`CockroachDB::FixturesTest#test_create_fixtures`: "flaky",
`TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_save_and_return_false_if_a_callback_cancelled_saving_in_either_create_or_update`: "flaky",
`TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_update_children_when_parent_creation_with_no_reason`: "flaky",
`TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_update_children_when_autosave_is_true_and_parent_is_new_but_child_is_not`: "flaky",
Expand Down

0 comments on commit 6f2b16c

Please sign in to comment.