-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
83653: Refactoring app.spec.tsx from Enzyme to React Testing Library r=nathanstilwell a=nathanstilwell 84603: vendor: bump Pebble to 6b9be031039a r=nicktrav a=jbowens ``` 6b9be031 internal/metamorphic: add block-property filter coverage 96254cc0 db: don't filter range deletions based on point-key block filters 13cc5cde db: refactor levelIter/mergingIter boundary interface 44e97f43 sstable: fix additional bounds check bugs e9467bc8 db: export ErrCorruption 9f3691a7 db: remove compaction/flush pacing b821342a db: remove compaction.atomicBytesIterated d3484a60 Revert "github: add action runner for automating issue labeling" ``` Close #83376. Release note: None 84632: ccl/sqlproxyccl: increase cluster name parsing length limit r=JeffSwenson a=jaylim-crl Previously, cluster names as part of proxy connection strings were restricted to 6 and 20 alphanumeric characters due to CockroachCloud's limit. There are plans to increase the length limit on the CockroachCloud side, so this length limit here has to be lifted. This commit increases the cluster name length limit from 20 characters to 100 characters. Note that the limit for cluster names within CockroachCloud is likely smaller than 100 characters. We don't do an exact match here for more flexibility on CockroachCloud's end. The limit was originally added to avoid sqlproxy from parsing long strings, which may be unreasonable. Given that 100 characters are not a lot when it comes to parsing, this change is acceptable. Release note: None Release justification: sqlproxyccl only change. Co-authored-by: Nathan Stilwell <[email protected]> Co-authored-by: Jackson Owens <[email protected]> Co-authored-by: Jay <[email protected]>
- Loading branch information
Showing
13 changed files
with
227 additions
and
301 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1431,10 +1431,10 @@ def go_deps(): | |
patches = [ | ||
"@com_github_cockroachdb_cockroach//build/patches:com_github_cockroachdb_pebble.patch", | ||
], | ||
sha256 = "1d37b28ca579f0d052ae51133945a47626dec63ceef0f07262aaedb033da1d25", | ||
strip_prefix = "github.com/cockroachdb/[email protected]20220706210916-d68c152233af", | ||
sha256 = "ba44b4818846bee833b98b11e22efa4c04efed9533ba16e8e7013a52a5cbc1ab", | ||
strip_prefix = "github.com/cockroachdb/[email protected]20220718171027-6b9be031039a", | ||
urls = [ | ||
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20220706210916-d68c152233af.zip", | ||
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20220718171027-6b9be031039a.zip", | ||
], | ||
) | ||
go_repository( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.