Skip to content

Commit

Permalink
Merge #74882
Browse files Browse the repository at this point in the history 
74882: execgen: add overloads for INTERVAL / INT4 and INTERVAL / INT2 r=mgartner a=mgartner

Vectorized overloads for `INTERVAL / INT4` and `INTERVAL / INT2`
expressions have been added. The omission of these overloads caused
errors only in rare cases because usually these expressions are retyped
to `INTERVAL / INT8` by the optimizer
[here](https://github.com/cockroachdb/cockroach/blob/583efd3cd9c7198bac935bb81a7a598e5849a269/pkg/sql/opt/optbuilder/scalar.go#L218).

Fixes #70738

Release note (bug fix): A bug has been fixed which caused errors in rare
cases when trying to divide `INTERVAL` values by `INT4` or `INT2`
values.

Co-authored-by: Marcus Gartner <[email protected]>
  • Loading branch information
@mgartner
craig[bot] and mgartner committed Jan 18, 2022
2 parents c116203 + 078c85a commit 6c04e8c
Show file tree
Hide file tree
Showing 5 changed files with 694 additions and 1 deletion.
220 changes: 220 additions & 0 deletions pkg/sql/colexec/colexecproj/proj_const_left_ops.eg.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 6c04e8c

Please sign in to comment.