Skip to content

Commit

Permalink
roachprod: do not send status report to slack
Browse files Browse the repository at this point in the history
Previously, the roachprod GC job posted cluster status on each run. This
made the #roachprod-status channel very spammy and not actionable.

This patch removes the status generation part.

Release note: None
  • Loading branch information
rail committed Mar 28, 2022
1 parent f8e03e2 commit 6a99140
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions pkg/roachprod/cloud/gc.go
Original file line number Diff line number Diff line change
Expand Up @@ -312,11 +312,7 @@ func GCClusters(l *logger.Logger, cloud *Cloud, dryrun bool) error {
}
}

// Send out notification to #roachprod-status.
client := makeSlackClient()
channel, _ := findChannel(client, "roachprod-status", "")
postStatus(l, client, channel, dryrun, &s, badVMs)

// Send out user notifications if any of the user's clusters are expired or
// will be destroyed.
for user, status := range users {
Expand All @@ -330,6 +326,7 @@ func GCClusters(l *logger.Logger, cloud *Cloud, dryrun bool) error {
}
}

channel, _ := findChannel(client, "roachprod-status", "")
if !dryrun {
if len(badVMs) > 0 {
// Destroy bad VMs.
Expand Down

0 comments on commit 6a99140

Please sign in to comment.