Skip to content

Commit

Permalink
wip: use tenants always, force list all failures
Browse files Browse the repository at this point in the history
This commit will be removed before the PR is merged.

Release note: None
  • Loading branch information
knz committed Sep 20, 2023
1 parent 10e1ea9 commit 6952e09
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion build/teamcity/cockroach/ci/tests/unit_tests_ccl_impl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ fi

$(bazel info bazel-bin --config=ci)/pkg/cmd/bazci/bazci_/bazci -- test --config=ci --config=use_ci_timeouts -c fastbuild \
//pkg:ccl_tests \
--profile=/artifacts/profile.gz $EXTRA_PARAMS
--profile=/artifacts/profile.gz -k $EXTRA_PARAMS
2 changes: 1 addition & 1 deletion build/teamcity/cockroach/ci/tests/unit_tests_impl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ fi

$(bazel info bazel-bin --config=ci)/pkg/cmd/bazci/bazci_/bazci -- test --config=ci --config=use_ci_timeouts -c fastbuild \
//pkg:small_non_ccl_tests //pkg:medium_non_ccl_tests //pkg:large_non_ccl_tests //pkg:enormous_non_ccl_tests \
--profile=/artifacts/profile.gz $EXTRA_PARAMS
--profile=/artifacts/profile.gz -k $EXTRA_PARAMS
4 changes: 3 additions & 1 deletion pkg/testutils/serverutils/test_server_shim.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,12 @@ func ShouldStartDefaultTestTenant(
return override
}

const alwaysEnabled = true

// Note: we ask the metamorphic framework for a "disable" value, instead
// of an "enable" value, because it probabilistically returns its default value
// more often than not and that is what we want.
enabled := !util.ConstantWithMetamorphicTestBoolWithoutLogging("disable-test-tenant", false)
enabled := alwaysEnabled || !util.ConstantWithMetamorphicTestBoolWithoutLogging("disable-test-tenant", false)
if enabled && t != nil {
t.Log(defaultTestTenantMessage)
}
Expand Down

0 comments on commit 6952e09

Please sign in to comment.