-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
100739: go.mod: bump Pebble to 16bf77ee4012 r=RaduBerinde a=RaduBerinde 16bf77ee shared: add IsNotExistError method to shared.Storage 93eff0a7 manifest: remove struct Atomic from FileBacking 6bf568d8 manifest: use atomic types in FileMetadata 67895e1d manifest: don't copy FileMetadata by value 7d5a3b7c db: use atomic types in Db a664f69f replay: use atomic types 9de87a35 vfs: use atomic.Uint32 for disk full generation 75b78212 pebble: use atomic.Int32 for memTable.writerRefs 44af3316 cmd/pebble: use atomic types 5e9ccb46 pebble: use atomic type in commitQueue 41fce88e *: use atomic types in tests e0a52f16 pebble: add TODO for FilterMetrics 18af1e35 pebble: use atomic types in table cache 49137e40 pebble: use atomic.Uint64 for sequence numbers e808d80d pebble: use atomic.Int32 for iterCount in tableCacheOpts 37f6c795 pebble: use atomic.Bool for Batch.applied c865bc3c pebble: use atomic.Int64 for TableCache refs Release note: none Epic: none 100814: upgrade: waitForDelRangeInGCJob should only wait for running jobs r=fqazi a=fqazi Previously, the logic to determine that all GC jobs were using DelRange was no-oped because in our testing environments, we always had: storage.mvcc.range_tombstones.enabled set. The mixed version tests for schema would always create GC jobs with DelRange and be fine. Once this default was changed we started to observe the behaviour of this migration was that it will wait till the GC interval before we would move to the next version. To address this, this patch fixes the check inside waitForDelRangeInGCJob to exclude GC jobs that haven't started any work. Fixes: #100732 Release note: None Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Faizan Qazi <[email protected]>
- Loading branch information
Showing
7 changed files
with
16 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1555,10 +1555,10 @@ def go_deps(): | |
patches = [ | ||
"@com_github_cockroachdb_cockroach//build/patches:com_github_cockroachdb_pebble.patch", | ||
], | ||
sha256 = "f282ddeea7d1c18f2acc37c252e6673b6d11c046a1c78bb28106bd7b8feea319", | ||
strip_prefix = "github.com/cockroachdb/[email protected]20230403163348-b84a7ec7d8dc", | ||
sha256 = "4ba6205e0829b82c4c0ece96e38c7be860684ae0dab725d745b0d5fd62fd93c8", | ||
strip_prefix = "github.com/cockroachdb/[email protected]20230405180252-16bf77ee4012", | ||
urls = [ | ||
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230403163348-b84a7ec7d8dc.zip", | ||
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230405180252-16bf77ee4012.zip", | ||
], | ||
) | ||
go_repository( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters