Skip to content

Commit

Permalink
roachpb: clarify ResolveIntent.Poison
Browse files Browse the repository at this point in the history
Specify that this field is ignored when resolving COMMITTED (or
otherwise non-ABORTED) intents (which it is). At lease the
rangefeedTxnPusher sets it for non-aborted transactions, leading to
question about whether that's a good idea.

Release note: None
  • Loading branch information
andreimatei committed Aug 20, 2020
1 parent 75dbf3d commit 6472305
Show file tree
Hide file tree
Showing 3 changed files with 146 additions and 134 deletions.
4 changes: 4 additions & 0 deletions pkg/kv/kvserver/intentresolver/intent_resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,10 @@ type ResolveOptions struct {
// ranges trying to read one of its old intents, the access will be trapped
// and the read will return an error, thus avoiding the read missing to see
// its own write.
//
// This field is ignored for intents that arent' resolved for an ABORTED txn;
// in other words only intents from ABORTED transactions ever poison the abort
// spans.
Poison bool
// The original transaction timestamp from the earliest txn epoch; if
// supplied, resolution of intent ranges can be optimized in some cases.
Expand Down
Loading

0 comments on commit 6472305

Please sign in to comment.