Skip to content

Commit

Permalink
sql: skip tests under race that may trigger a fixed race in conn exec…
Browse files Browse the repository at this point in the history
…utor

This PR skips TestTenantTempTableCleanup under race, since they can
trigger a race in conn executor that has been mostly fixed.

Epic: None
Fixes: #117104

Release note: None
  • Loading branch information
rharding6373 committed Jan 4, 2024
1 parent 9a49e00 commit 634e0dd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/ccl/testccl/sqlccl/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ go_test(
"//pkg/sql/tests",
"//pkg/testutils",
"//pkg/testutils/serverutils",
"//pkg/testutils/skip",
"//pkg/testutils/sqlutils",
"//pkg/testutils/testcluster",
"//pkg/util/hlc",
Expand Down
2 changes: 2 additions & 0 deletions pkg/ccl/testccl/sqlccl/temp_table_clean_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql"
"github.com/cockroachdb/cockroach/pkg/sql/sqlliveness/slinstance"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
"github.com/cockroachdb/cockroach/pkg/util/leaktest"
"github.com/cockroachdb/cockroach/pkg/util/stop"
Expand All @@ -26,6 +27,7 @@ import (

func TestTenantTempTableCleanup(t *testing.T) {
defer leaktest.AfterTest(t)()
skip.UnderRace(t, "May cause a conn executor race fixed by #114783")

ctx := context.Background()
t.Helper()
Expand Down

0 comments on commit 634e0dd

Please sign in to comment.