Merge #121245 #121293 #121860 #121903

121245: storage: support disk stall tracing r=aadityasondhi a=CheranMahalingam

Currently, in the event of a disk stall we don't have visibility into the sequence of disk events that led up to the failure due to the 10s frequency at which we export disk metrics. This commit adds support for storing a history of disk events from the previous 30s and in the event of a stall, logs a trace.

Fixes: #120506.
Informs: #89786.

Epic: None.
Release note: None.

121293: sql: allow ALTER DATABASE PRIMARY REGION to work on system tenants r=jasminejsun a=jasminejsun

Previously, on a multi-region setup the system database could not be modified to be multi-region and it was blocked from being made multi-region aware. To address this, we are now allowing ALTER DATABASE PRIMARY REGION to work on system tenants.

Fixes: #63365
Epic: CRDB-33032

Release note (sql change): Previously, we added support for settings reegion on the system database, which was limited to tenants only. We lifted this limitation to allow ALTER DATABASE PRIMARY REGION to work on system tenants. To support preview status, we created a cluster setting called sql.multiregion.preview_multiregion_system_database that will give users the option to set up their system database as multi-region for Cockroach dedicated (this cluster setting is not enabled by default). Note that after adding non-primary regions, we recommend that users do a rolling restart to propogate region information.

121860: roachtest: simpler preempted instance names r=herkolategan a=renatolabs

Small change to make them easier for a person to read.

Epic: none

Release note: None

121903: sql: avoid an allocation in checkExprForDistSQL r=yuzefovich a=yuzefovich

This commit removes an allocation of `distSQLExprCheckVisitor` that previously happened on each `checkExprForDistSQL` call. We now reuse the same visitor that is stored on the `planner`. In some profiles I looked at recently this allocation accounted for over 1% of all allocations.

Fixes: #121302.

Release note: None

Co-authored-by: Cheran Mahalingam <[email protected]>
Co-authored-by: Jasmine Sun <[email protected]>
Co-authored-by: Renato Costa <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>

pkg/ccl/logictestccl/testdata/logic_test/multi_region

@@ -544,7 +544,7 @@ ALTER DATABASE system PRIMARY REGION "ap-southeast-2"
 # are in the system tenant. Hence the lack of error code checking and the
 # regex matching both possible outcomes.
 skipif config multiregion-9node-3region-3azs-tenant
-statement error user testuser may not modify the system database|modifying the regions of system database is not supported
+statement error user testuser may not modify the system database|Modifying the regions of system database is not supported. Set up your system database as multi-region using the cluster setting `sql.multiregion.preview_multiregion_system_database.enabled` https://www.cockroachlabs.com/docs/stable/cluster-settings
 ALTER DATABASE system PRIMARY REGION "ap-southeast-2"
 
 user root