Skip to content

Commit

Permalink
Merge #137075
Browse files Browse the repository at this point in the history
137075: workflow: remove cockroach-microbench-ci r=srosenberg a=sambhav-jain-16

Following the discussions in
#135899. This job is being removed until we are able to figure out how to remove the variance in microbenchmarks #106661

Epic: none

Release note: None

Co-authored-by: Sambhav Jain <[email protected]>
  • Loading branch information
craig[bot] and sambhav-jain-16 committed Dec 10, 2024
2 parents de3b122 + af6f42f commit 5f83714
Showing 1 changed file with 0 additions and 50 deletions.
50 changes: 0 additions & 50 deletions .github/workflows/github-actions-essential-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -345,54 +345,4 @@ jobs:
- name: clean up
run: ./build/github/cleanup-engflow-keys.sh
if: always()
cockroach-microbench-ci:
runs-on: [ self-hosted, basic_runner_group ]
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 1 # Fetch only the latest commit

- name: Get the latest commit of the target branch
id: get_latest_commit_target_branch
run: |
# Get the target branch name
TARGET_BRANCH=${{ github.event.pull_request.base.ref }}
# Fetch the latest commit of the target branch
git fetch origin $TARGET_BRANCH --depth=1
# Get the latest commit hash of the target branch
LATEST_COMMIT=$(git rev-parse FETCH_HEAD)
# Output the latest commit hash
echo "Latest commit on target branch ($TARGET_BRANCH): $LATEST_COMMIT"
# Set the latest commit hash as an output variable
echo "latest_commit=$LATEST_COMMIT" >> $GITHUB_OUTPUT
if: ${{ github.event_name != 'push' }}
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha || github.ref }}
- name: compute metadata
run: echo GITHUB_ACTIONS_BRANCH=${{ github.event.pull_request.number || github.ref_name}} >> "$GITHUB_ENV"
- run: ./build/github/get-engflow-keys.sh
- run: ./build/github/prepare-summarize-build.sh
- name: run scripts
run: ./build/github/cockroach-microbench-ci.sh
env:
COMPARE_THRESHOLD: "20.00"
PUSH_STEP: ${{ github.event_name == 'push' && env.GITHUB_ACTIONS_BRANCH != 'staging' }}
BASE_SHA: ${{ steps.get_latest_commit_target_branch.outputs.latest_commit }}

# TODO(sambhav-jain-16): add Performance note check and use this flag. Currently set to false (https://github.com/cockroachdb/cockroach/issues/106661)
SKIP_COMPARISON: ${{ env.GITHUB_ACTIONS_BRANCH == 'staging' }}
- name: upload build results
run: ./build/github/summarize-build.sh bes.bin
if: always()
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: clean up
run: ./build/github/cleanup-engflow-keys.sh
if: always()

0 comments on commit 5f83714

Please sign in to comment.