Merge #28634

28634: server: Fix EnqueueRange test flake r=a-robinson a=a-robinson

The test could flake if a range lease got transferred during one of the
test cases in such a way that none of the stores confidently owned the
lease at the time that the request made it to them. To fix the flake,
just disable automatic replication / lease transfers in the test.

Fixes #28610

Release note: None

Co-authored-by: Alex Robinson <[email protected]>

pkg/server/admin_test.go

@@ -1475,9 +1475,19 @@ func BenchmarkAdminAPIDataDistribution(b *testing.B) {
 
 func TestEnqueueRange(t *testing.T) {
 	defer leaktest.AfterTest(t)()
-	testCluster := serverutils.StartTestCluster(t, 3, base.TestClusterArgs{})
+	testCluster := serverutils.StartTestCluster(t, 3, base.TestClusterArgs{
+		ReplicationMode: base.ReplicationManual,
+	})
 	defer testCluster.Stopper().Stop(context.Background())
 
+	// Up-replicate r1 to all 3 nodes. We use manual replication to avoid lease
+	// transfers causing temporary conditions in which no store is the
+	// leaseholder, which can break the the tests below.
+	_, err := testCluster.AddReplicas(roachpb.KeyMin, testCluster.Target(1), testCluster.Target(2))
+	if err != nil {
+		t.Fatal(err)
+	}
+
 	// RangeID being queued
 	const realRangeID = 1
 	const fakeRangeID = 999