Merge #136377

136377: roachtest: backup-restore/small-ranges gather debug zip files r=fqazi a=fqazi Previously, if the backup-restore tests had workload errors before the cluster was wiped then only debug zip data from after wiping the cluster would be kept. This would make workload issues impossible to diagnose / resolve if the problem was inside the CRDB code base, To address this, this patch adds logic to take a debug zip before wiping the cluster. Fixes: #134928 Release note: None Co-authored-by: Faizan Qazi <[email protected]>
cockroachdb · Dec 4, 2024 · 535f8f3 · 535f8f3
2 parents d87d473 + db82a7a
commit 535f8f3
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/cmd/roachtest/tests/backup_restore_roundtrip.go b/pkg/cmd/roachtest/tests/backup_restore_roundtrip.go
@@ -186,6 +186,11 @@ func backupRestoreRoundTrip(
 					m.ExpectDeaths(int32(n))
 				}
 
+				// Between each reset grab a debug zip from the cluster.
+				zipPath := fmt.Sprintf("debug-%d.zip", timeutil.Now().Unix())
+				if err := testUtils.cluster.FetchDebugZip(ctx, t.L(), zipPath); err != nil {
+					t.L().Printf("failed to fetch a debug zip: %v", err)
+				}
 				if err := testUtils.resetCluster(ctx, t.L(), clusterupgrade.CurrentVersion(), expectDeathsFn, []install.ClusterSettingOption{}); err != nil {
 					return err
 				}