-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
87763: changefeedccl: mark kv senderrors retryable r=samiskin a=samiskin Resolves #87300 Changefeeds can encounter senderrors during a normal upgrade procedure and therefore should retry. This was done in the kvfeed however is apparently not high level enough as a send error was still observed to cause a permanent failure. This PR moves the senderror checking to the top level IsRetryable check to handle it regardless of its source. Release justification: low risk important bug fix Release note (bug fix): Changefeeds will now never permanently error on a "failed to send RPC" error. 89445: opt: assert that inverted scans have inverted constraints r=mgartner a=mgartner This commit adds an assertion to ensure that inverted index scans have inverted constraints. If they do not, there is a likely a bug that can cause incorrect query results (e.g., #88047). This assertion is made in release builds,not just test builds, because it is cheap to perform. Fixes #89440 Release note: None 89482: roachtests: introduce admission-control/elastic-backup r=irfansharif a=irfansharif Informs #89208. This test sets up a 3-node CRDB cluster on 8vCPU machines running 1000-warehouse TPC-C with an aggressive (every 20m) full backup schedule. We've observed latency spikes during backups because of its CPU-heavy nature -- it can elevate CPU scheduling latencies which in turn translates to an increase in foreground latency. In #86638 we introduced admission control mechanisms to dynamically pace such work while maintaining acceptable CPU scheduling latencies (sub millisecond p99s). This roachtest exercises that machinery. In future commits we'll add libraries to the roachtest package to automatically spit out the degree to which {CPU-scheduler,foreground} latencies are protected. Release note: None Co-authored-by: Shiranka Miskin <[email protected]> Co-authored-by: Marcus Gartner <[email protected]> Co-authored-by: irfan sharif <[email protected]>
- Loading branch information
Showing
12 changed files
with
213 additions
and
49 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
pkg/cmd/roachtest/tests/admission_control_elastic_backup.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| // Copyright 2022 The Cockroach Authors. | ||
| // | ||
| // Use of this software is governed by the Business Source License | ||
| // included in the file licenses/BSL.txt. | ||
| // | ||
| // As of the Change Date specified in that file, in accordance with | ||
| // the Business Source License, use of this software will be governed | ||
| // by the Apache License, Version 2.0, included in the file | ||
| // licenses/APL.txt. | ||
|
|
||
| package tests | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "time" | ||
|
|
||
| "github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster" | ||
| "github.com/cockroachdb/cockroach/pkg/cmd/roachtest/registry" | ||
| "github.com/cockroachdb/cockroach/pkg/cmd/roachtest/spec" | ||
| "github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test" | ||
| "github.com/cockroachdb/cockroach/pkg/roachprod/prometheus" | ||
| ) | ||
|
|
||
| // This test sets up a 3-node CRDB cluster on 8vCPU machines running | ||
| // 1000-warehouse TPC-C with an aggressive (every 20m) full backup schedule. | ||
| // We've observed latency spikes during backups because of its CPU-heavy nature | ||
| // -- it can elevate CPU scheduling latencies which in turn translates to an | ||
| // increase in foreground latency. In #86638 we introduced admission control | ||
| // mechanisms to dynamically pace such work while maintaining acceptable CPU | ||
| // scheduling latencies (sub millisecond p99s). This roachtest exercises that | ||
| // machinery. | ||
| // | ||
| // TODO(irfansharif): Add libraries to automatically spit out the degree to | ||
| // which {CPU-scheduler,foreground} latencies are protected and track this data | ||
| // in roachperf. | ||
| func registerElasticControlForBackups(r registry.Registry) { | ||
| r.Add(registry.TestSpec{ | ||
| Name: "admission-control/elastic-backup", | ||
| Owner: registry.OwnerAdmissionControl, | ||
| // TODO(irfansharif): After two weeks of nightly baking time, reduce | ||
| // this to a weekly cadence. This is a long-running test and serves only | ||
| // as a coarse-grained benchmark. | ||
| // Tags: []string{`weekly`}, | ||
| Cluster: r.MakeClusterSpec(4, spec.CPU(8)), | ||
| Run: func(ctx context.Context, t test.Test, c cluster.Cluster) { | ||
| if c.Spec().NodeCount < 4 { | ||
| t.Fatalf("expected at least 4 nodes, found %d", c.Spec().NodeCount) | ||
| } | ||
|
|
||
| crdbNodes := c.Spec().NodeCount - 1 | ||
| workloadNode := crdbNodes + 1 | ||
| numWarehouses, workloadDuration, estimatedSetupTime := 1000, 90*time.Minute, 10*time.Minute | ||
| if c.IsLocal() { | ||
| numWarehouses, workloadDuration, estimatedSetupTime = 1, time.Minute, 2*time.Minute | ||
| } | ||
|
|
||
| promCfg := &prometheus.Config{} | ||
| promCfg.WithPrometheusNode(c.Node(workloadNode).InstallNodes()[0]). | ||
| WithNodeExporter(c.Range(1, c.Spec().NodeCount-1).InstallNodes()). | ||
| WithCluster(c.Range(1, c.Spec().NodeCount-1).InstallNodes()). | ||
| WithGrafanaDashboard("http://go.crdb.dev/p/backup-admission-control-grafana"). | ||
| WithScrapeConfigs( | ||
| prometheus.MakeWorkloadScrapeConfig("workload", "/", | ||
| makeWorkloadScrapeNodes( | ||
| c.Node(workloadNode).InstallNodes()[0], | ||
| []workloadInstance{{nodes: c.Node(workloadNode)}}, | ||
| ), | ||
| ), | ||
| ) | ||
|
|
||
| if t.SkipInit() { | ||
| t.Status(fmt.Sprintf("running tpcc for %s (<%s)", workloadDuration, time.Minute)) | ||
| } else { | ||
| t.Status(fmt.Sprintf("initializing + running tpcc for %s (<%s)", workloadDuration, 10*time.Minute)) | ||
| } | ||
|
|
||
| runTPCC(ctx, t, c, tpccOptions{ | ||
| Warehouses: numWarehouses, | ||
| Duration: workloadDuration, | ||
| SetupType: usingImport, | ||
| EstimatedSetupTime: estimatedSetupTime, | ||
| SkipPostRunCheck: true, | ||
| ExtraSetupArgs: "--checks=false", | ||
| PrometheusConfig: promCfg, | ||
| During: func(ctx context.Context) error { | ||
| db := c.Conn(ctx, t.L(), crdbNodes) | ||
| defer db.Close() | ||
|
|
||
| t.Status(fmt.Sprintf("during: enabling admission control (<%s)", 30*time.Second)) | ||
| setAdmissionControl(ctx, t, c, true) | ||
|
|
||
| m := c.NewMonitor(ctx, c.Range(1, crdbNodes)) | ||
| m.Go(func(ctx context.Context) error { | ||
| t.Status(fmt.Sprintf("during: creating full backup schedule to run every 20m (<%s)", time.Minute)) | ||
| _, err := db.ExecContext(ctx, | ||
| `CREATE SCHEDULE FOR BACKUP INTO $1 RECURRING '*/20 * * * *' FULL BACKUP ALWAYS WITH SCHEDULE OPTIONS ignore_existing_backups;`, | ||
| "gs://cockroachdb-backup-testing/"+c.Name()+"?AUTH=implicit", | ||
| ) | ||
| return err | ||
| }) | ||
| m.Wait() | ||
|
|
||
| t.Status(fmt.Sprintf("during: waiting for workload to finish (<%s)", workloadDuration)) | ||
| return nil | ||
| }, | ||
| }) | ||
| }, | ||
| }) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.