-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sql: fall back to raw SQL for statement diagnostics bundle
When gathering the statement for a statement diagnostics bundle, fall back to using the raw SQL when we cannot pretty-print the statement AST, which happens for statements that fail with certain errors. (This also fixes a crash in addTrace, which was not handling these error cases. It looks like this crash was partially fixed in #56768 but not completely.) Fixes: #94416 #56705 Epic: None Release note (bug fix): Fix a crash that occurs on the gateway node when collecting a statement diagnostics bundle (e.g. `EXPLAIN ANALYZE (DEBUG)`) on a statement that fails with certain errors. This crash has existed in various forms since the introduction of statement bundles in v20.1.0.
- Loading branch information
Showing
2 changed files
with
39 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters