Skip to content

Commit

Permalink
testccl/sqlccl: unskip TestExplainRedactDDL
Browse files Browse the repository at this point in the history
`TestExplainRedactDDL` is a randomized SQL test which runs variants of
`EXPLAIN (REDACT)` on random SQL statements and checks that an injected
poison string is always redacted in the output. It is very similar to
another randomized test, `TestExplainRedact`, but also includes DDL in
the random statements.

During development of v23.1 this test was skipped because the random DDL
statements were running into other bugs unrelated to redaction. Now that
things are more stable, let's unskip this test.

Fixes: #99005

Epic: None

Release note: None
  • Loading branch information
michae2 committed Jun 26, 2023
1 parent 82115b8 commit 4d46652
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions pkg/ccl/testccl/sqlccl/explain_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/lexbase"
"github.com/cockroachdb/cockroach/pkg/sql/tests"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/util/leaktest"
"github.com/cockroachdb/cockroach/pkg/util/log"
"github.com/cockroachdb/cockroach/pkg/util/randutil"
Expand All @@ -33,9 +32,6 @@ func TestExplainRedactDDL(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

skip.WithIssue(t, 99005)
skip.UnderStressWithIssue(t, 99005)

const numStatements = 10

ctx := context.Background()
Expand Down

0 comments on commit 4d46652

Please sign in to comment.