Skip to content

Commit

Permalink
util/admission: add TODO to explain "grant chains" further
Browse files Browse the repository at this point in the history
  • Loading branch information
nvanbenschoten committed Mar 28, 2022
1 parent 091221e commit 4a696f2
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pkg/util/admission/granter.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,13 @@ type granter interface {
// 5x and shifted ~2s of latency (at p99) from the scheduler into admission
// control (which is desirable since the latter is where we can
// differentiate between work).
//
// TODO(sumeer): the "grant chain" concept is subtle and under-documented.
// It's easy to go through most of this package thinking it has something to
// do with dependent requests (e.g. intent resolution chains on an end txn).
// It would help for a top-level comment on grantChainID or continueGrantChain
// to spell out what grant chains are, their purpose, and how they work with
// an example.
continueGrantChain(grantChainID grantChainID)
}

Expand Down

0 comments on commit 4a696f2

Please sign in to comment.