Skip to content

Commit

Permalink
Merge #137383
Browse files Browse the repository at this point in the history
137383: roachtest: use new ruby version for activerecord test r=rafiss a=rafiss

The latest version of this package needs ruby3.3 in order to pick up this change:
ruby/ruby@7e5c662

Otherwise, these tests fail with:
```
ArgumentError: wrong number of arguments (given 2, expected 0..1)
    /usr/local/lib/ruby/3.1.0/random/formatter.rb:213:in `alphanumeric'
    /usr/local/lib/ruby/gems/3.1.0/bundler/gems/rails-6cfa24f9dfdd/activesupport/lib/active_support/core_ext/securerandom.rb:20:in `base58'
    ...
```

fixes #136562
fixes #136876
fixes #136560
Release note: None

Co-authored-by: Rafi Shamim <[email protected]>
  • Loading branch information
craig[bot] and rafiss committed Dec 13, 2024
2 parents 8919614 + 476b683 commit 42593c0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/cmd/roachtest/tests/activerecord.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,11 @@ func registerActiveRecord(r registry.Registry) {
t,
c,
node,
"install ruby 3.1",
"install ruby 3.3",
`mkdir -p ruby-install && \
curl -fsSL https://github.com/postmodern/ruby-install/archive/v0.9.1.tar.gz | tar --strip-components=1 -C ruby-install -xz && \
sudo make -C ruby-install install && \
sudo ruby-install --system ruby 3.1.4 && \
sudo ruby-install --system ruby 3.3.6 && \
sudo gem update --system`,
); err != nil {
t.Fatal(err)
Expand Down Expand Up @@ -146,7 +146,7 @@ func registerActiveRecord(r registry.Registry) {
c,
node,
"installing bundler",
`cd /mnt/data1/activerecord-cockroachdb-adapter/ && sudo gem install bundler:2.4.9`,
`cd /mnt/data1/activerecord-cockroachdb-adapter/ && sudo gem install bundler:2.5.23`,
); err != nil {
t.Fatal(err)
}
Expand Down

0 comments on commit 42593c0

Please sign in to comment.