Skip to content

Commit

Permalink
roachprod: remove COCKROACH_UI_RELEASE_NOTES_SIGNUP_DISMISSED
Browse files Browse the repository at this point in the history
Remove COCKROACH_UI_RELEASE_NOTES_SIGNUP_DISMISSED which
had previously been used by roachprod circa 2020, until it
got reverted in [1]. It has no effect after the PR which reverted
the related change.

Release note: None
Epic: None

[1] #57003
  • Loading branch information
srosenberg committed Dec 6, 2022
1 parent 146556e commit 3b8e08a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions pkg/roachprod/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ func DefaultEnvVars() []string {
// when moving snapshots around, though.
// (For other perf. related knobs, see https://github.com/cockroachdb/cockroach/issues/17165)
"COCKROACH_ENABLE_RPC_COMPRESSION=false",
// Get rid of an annoying popup in the UI.
"COCKROACH_UI_RELEASE_NOTES_SIGNUP_DISMISSED=true",
// Allow upgrading a stable release data-dir to a dev version.
// N.B. many roachtests which perform upgrade scenarios require this env. var after changes in [1]; otherwise,
// the tests will fail even on release branches when attempting to upgrade previous (stable) release to an alpha.
Expand Down

0 comments on commit 3b8e08a

Please sign in to comment.