Merge #62490

62490: delegate: order AZs in SHOW REGIONS commands r=ajstorm a=otan Release note (sql change): Availability zones were not ordered when using the SHOW REGIONS set of commands. This has now been changed to be ordered. Co-authored-by: Oliver Tan <[email protected]>
cockroachdb · Mar 24, 2021 · 37f5694 · 37f5694
2 parents 9fa4b12 + 64f909f
commit 37f5694
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/pkg/cli/interactive_tests/test_demo_global.tcl b/pkg/cli/interactive_tests/test_demo_global.tcl
@@ -13,6 +13,13 @@ spawn $argv demo --no-example-database --nodes 9 --global
 # Ensure db is defaultdb.
 eexpect "defaultdb>"
 
+# Ensure regions display correctly.
+send "SELECT region, zones FROM \[SHOW REGIONS FROM CLUSTER\] ORDER BY region;\r"
+eexpect "  europe-west1 | {b,c,d}"
+eexpect "  us-east1     | {b,c,d}"
+eexpect "  us-west1     | {a,b,c}"
+eexpect "defaultdb>"
+
 interrupt
 eexpect eof
 end_test
diff --git a/pkg/sql/delegate/show_regions.go b/pkg/sql/delegate/show_regions.go
@@ -36,6 +36,7 @@ func (d *delegator) delegateShowRegions(n *tree.ShowRegions) (tree.Statement, er
 							'zone=([^,]*)'
 						)
 					)
+					ORDER BY locality
 				),
 				NULL
 			)
-Original file line number
+Diff line change
@@ Expand Up @@
     							'zone=([^,]*)'
     						)
     					)
+    					ORDER BY locality
     				),
     				NULL
     			)
@@ Expand Down @@