sql: add index check for virtualTables

Check that the indexes in the schema for the virtualTable matches the
number of index array elements.

Release note: None

pkg/sql/BUILD.bazel

@@ -584,6 +584,7 @@ go_test(
         "//pkg/sql/catalog/descs",
         "//pkg/sql/catalog/lease",
         "//pkg/sql/catalog/multiregion",
+        "//pkg/sql/catalog/schemadesc",
         "//pkg/sql/catalog/systemschema",
         "//pkg/sql/catalog/tabledesc",
         "//pkg/sql/catalog/typedesc",

pkg/sql/virtual_schema_test.go

@@ -24,14 +24,18 @@ package sql
 
 import (
 	"bufio"
+	"context"
 	"flag"
 	"fmt"
 	"os"
 	"strings"
 	"testing"
 
+	"github.com/cockroachdb/cockroach/pkg/settings/cluster"
+	"github.com/cockroachdb/cockroach/pkg/sql/catalog/schemadesc"
 	"github.com/cockroachdb/cockroach/pkg/util/leaktest"
 	"github.com/cockroachdb/cockroach/pkg/util/log"
+	"github.com/stretchr/testify/require"
 )
 
 var rewriteTables = flag.Bool(
@@ -49,7 +53,9 @@ func TestVirtualSchemas(t *testing.T) {
 	defer leaktest.AfterTest(t)()
 	defer log.Scope(t).Close(t)
 
-	for _, schema := range virtualSchemas {
+	ctx := context.Background()
+
+	for schemaID, schema := range virtualSchemas {
 		_, isSchemaFixable := fixableSchemas[schema.name]
 		if len(schema.undefinedTables) == 0 || !isSchemaFixable {
 			continue
@@ -64,7 +70,7 @@ func TestVirtualSchemas(t *testing.T) {
 			rewriteSchema(schema.name, unimplementedTables)
 		} else {
 			t.Run(fmt.Sprintf("VirtualSchemaTest/%s", schema.name), func(t *testing.T) {
-				for _, virtualTable := range schema.tableDefs {
+				for tableID, virtualTable := range schema.tableDefs {
 					tableName, err := getTableNameFromCreateTable(virtualTable.getSchema())
 					if err != nil {
 						t.Fatal(err)
@@ -76,6 +82,27 @@ func TestVirtualSchemas(t *testing.T) {
 							tableName,
 						)
 					}
+
+					// Sanity check indexes are all defined.
+					sc, ok := schemadesc.GetVirtualSchemaByID(schemaID)
+					require.True(t, ok)
+					d, err := virtualTable.initVirtualTableDesc(
+						ctx,
+						cluster.MakeClusterSettings(),
+						sc,
+						tableID,
+					)
+					require.NoError(t, err)
+					switch virtualTable := virtualTable.(type) {
+					case *virtualSchemaTable:
+						require.Equalf(
+							t,
+							len(d.GetIndexes()),
+							len(virtualTable.indexes),
+							"number of indexes in description must match number of indexes defined for table %s",
+							d.GetName(),
+						)
+					}
 				}
 			})
 		}