Merge #126884

126884: roachprod-microbench: address review comments in clean command r=renatolabs a=sambhav-jain-16 There were post-review comments in #126810. This change aims to address those. Epic: none Release note: None Co-authored-by: Sambhav Jain <[email protected]>
cockroachdb · Jul 16, 2024 · 34290f5 · 34290f5
2 parents 73ecc8b + 4e29fe1
commit 34290f5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/pkg/cmd/roachprod-microbench/clean.go b/pkg/cmd/roachprod-microbench/clean.go
@@ -30,13 +30,6 @@ type clean struct {
 	inputFile *os.File
 }
 
-func defaultCleanConfig() cleanConfig {
-	return cleanConfig{
-		inputFilePath:  "",
-		outputFilePath: "",
-	}
-}
-
 func newClean(config cleanConfig) (*clean, error) {
 	file, err := os.Open(config.inputFilePath)
 	if err != nil {

diff --git a/pkg/cmd/roachprod-microbench/main.go b/pkg/cmd/roachprod-microbench/main.go
@@ -54,9 +54,8 @@ Typical usage:
 }
 
 func makeCleanCommand() *cobra.Command {
-	config := defaultCleanConfig()
-	runCmdFunc := func(cmd *cobra.Command, commandLine []string) error {
-		args, _ := splitArgsAtDash(cmd, commandLine)
+	var config cleanConfig
+	runCmdFunc := func(cmd *cobra.Command, args []string) error {
 
 		config.inputFilePath = args[0]
 		config.outputFilePath = args[1]
@@ -69,8 +68,8 @@ func makeCleanCommand() *cobra.Command {
 	}
 	command := &cobra.Command{
 		Use:   "clean <inputFilePath> <outputFilePath>",
-		Short: "remove noisy logs from the benchmark output and dump it to a file",
-		Long:  `remove noisy logs from the benchmark output and dump it to a file`,
+		Short: "Summarise the benchmark output from the input file and write the summary to the output file",
+		Long:  `Summarise the benchmark output from the input file and write the summary to the output file`,
 		Args:  cobra.ExactArgs(2),
 		RunE:  runCmdFunc,
 	}