Skip to content

Commit

Permalink
kvcoord: change x-locality log from vevent to vinfo
Browse files Browse the repository at this point in the history
The X-locality log events were added in #103963 for the dist sender, to
alert when localities were misconfigured. In some clusters, especially
test clusters, these events are unnecessarily verbose in traces.

Change the log from `VEvent(5)` to `VInfo(5)` in the dist sender path.

Resolves: #110648
Epic: none
Release note: None
  • Loading branch information
kvoli committed Sep 29, 2023
1 parent 5086cd7 commit 3412f90
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/kv/kvclient/kvcoord/dist_sender.go
Original file line number Diff line number Diff line change
Expand Up @@ -2653,10 +2653,10 @@ func (ds *DistSender) getLocalityComparison(

comparisonResult, regionErr, zoneErr := gatewayNodeDesc.Locality.CompareWithLocality(destinationNodeDesc.Locality)
if regionErr != nil {
log.VEventf(ctx, 5, "unable to determine if the given nodes are cross region %v", regionErr)
log.VInfof(ctx, 5, "unable to determine if the given nodes are cross region %v", regionErr)
}
if zoneErr != nil {
log.VEventf(ctx, 5, "unable to determine if the given nodes are cross zone %v", zoneErr)
log.VInfof(ctx, 5, "unable to determine if the given nodes are cross zone %v", zoneErr)
}
return comparisonResult
}
Expand Down

0 comments on commit 3412f90

Please sign in to comment.