Skip to content

Commit

Permalink
roachtest: pin liveness lease to live node in lease prefs test
Browse files Browse the repository at this point in the history
The lease preferences roachtest could occasionally fail, if the liveness
leaseholder were on a stopped node. We should address this issue,
for now, pin the liveness lease to a live node to prevent flakes.

Informs: #108512
Resolves: #108425
Release note: None
  • Loading branch information
kvoli committed Aug 10, 2023
1 parent 1fd3eb8 commit 31b24e5
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions pkg/cmd/roachtest/tests/lease_preferences.go
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,14 @@ func runLeasePreferences(
// enforcement.
require.NoError(t, WaitForReplication(ctx, t, conn, spec.replFactor))

// Set a lease preference for the liveness range, to be on n5. This test
// would occasionally fail due to the liveness heartbeat failures, when the
// liveness lease is on a stopped node. This is not ideal behavior, #108512.
configureZone(t, ctx, conn, "RANGE liveness", zoneConfig{
replicas: spec.replFactor,
leaseNode: 5,
})

t.L().Printf("setting lease preferences: %s", spec.preferences)
setLeasePreferences(ctx, spec.preferences)
t.L().Printf("waiting for initial lease preference conformance")
Expand Down

0 comments on commit 31b24e5

Please sign in to comment.