Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
roachprod: fix
fileExistsOnFirstNode
check
For some reason, the current form of `fileExistsOnFirstNode` can return `found=true` when it should return `found=false`. This can be reproduced by running the `multitenant-upgrade` roachtest and seeing it hang at: ``` multitenant_upgrade.go:154: test status: checking the pre-upgrade sql server still works after the system tenant binary upgrade ``` because of a `TLS handshake error`. Note: the test is also broken because of another issue so with this fix it should now fail with: ``` (assertions.go:333).Fail: Error Trace: github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/multitenant_upgrade.go:390 github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/multitenant_upgrade.go:189 github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/multitenant_upgrade.go:38 main/pkg/cmd/roachtest/test_runner.go:1060 GOROOT/src/runtime/asm_arm64.s:1172 Error: Not equal: expected: [][]string{[]string{"23.1"}} actual : [][]string{[]string{"22.2"}} Diff: --- Expected +++ Actual @@ -2,3 +2,3 @@ ([]string) (len=1) { - (string) (len=4) "23.1" + (string) (len=4) "22.2" } Test: multitenant-upgrade ``` Release note: None Epic: none
- Loading branch information