Merge #61445

61445: kvserverpb: fix ClosedTimestamp comment r=andreimatei a=andreimatei The comment on ClosedTimestamp.RaftCommand was claiming that lease requests don't use that field. That's false - they do; they assign it to the lease start. Lease extensions don't use it, but also don't do anything special as it was indicated by the comment. Release note: None Release justification: Only comments Co-authored-by: Andrei Matei <[email protected]>
cockroachdb · Mar 4, 2021 · 2e04b55 · 2e04b55
2 parents ad5662b + ef09c3d
commit 2e04b55
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 21 deletions.
diff --git a/pkg/kv/kvserver/kvserverpb/proposer_kv.pb.go b/pkg/kv/kvserver/kvserverpb/proposer_kv.pb.go
diff --git a/pkg/kv/kvserver/kvserverpb/proposer_kv.proto b/pkg/kv/kvserver/kvserverpb/proposer_kv.proto
@@ -285,9 +285,8 @@ message RaftCommand {
   // used after this command is applied.
   //
   // The field can be zero, which is to be interpreted as no closed timestamp
-  // update. Some commands (lease requests) implicitly carry a closed timestamp
-  // in a command-specific way. If the value is not zero, the value is greater
-  // or equal to that of the previous commands (and all before it).
+  // update. If the value is not zero, the value is greater or equal to that of
+  // the previous commands (and all before it).
   //
   // This field is set through ClosedTimestampFooter hackery. Unlike in the
   // ClosedTimestampFooter, the field is nullable here so that it does not get