Skip to content

Commit

Permalink
roachtest: inc wait to 10m for token return in perturbation tests
Browse files Browse the repository at this point in the history
We assert that tokens are returned at the end of the `perturbation/*`
roachtests. However, we only waited 5 seconds before failing the
assertion. As the comment in this patch suggests, draining a send queue
can take longer as the node paces its catchup. In such cases, it is
acceptable that tokens are not returned within the lesser duration.

Bump this duration to 10 minutes.

Fixes: #136297
Release note: None
  • Loading branch information
kvoli committed Nov 27, 2024
1 parent 83f3395 commit 2b545c9
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pkg/cmd/roachtest/roachtestutil/validation_check.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,10 @@ func ValidateTokensReturned(
}
}
return nil
}, 5*time.Second)
// We wait up to 10 minutes for the tokens to be returned. In tests which
// purposefully create a send queue towards a node, the queue may take a
// while to drain. The tokens will not be returned until the queue is
// empty and there are no inflight requests.
}, 10*time.Minute)
}
}

0 comments on commit 2b545c9

Please sign in to comment.