Skip to content

Commit

Permalink
changefeedccl: update tests to random tenant random sink
Browse files Browse the repository at this point in the history
Previously most of our tests did not run on tenants as it was not
ergonomic to do so given our helpers.  We would also manually run tests
across multiple sinks even if the test did not care about what sink it
was ran on, drastically increasing the execution time of our test suite.

This PR updates our helper infrastructure to use a shared TestServer
struct that allows access to both the system and secondary tenant
interfaces, and by default runs tests on a random sink.

It also fixes a bug in the Webhook and Cloudstorage testfeeds where
>53bit numbers were rounded off due to JSON parsing.

Release note: None
  • Loading branch information
samiskin committed Jun 7, 2022
1 parent ba4d29e commit 24d490e
Show file tree
Hide file tree
Showing 14 changed files with 970 additions and 1,157 deletions.
6 changes: 0 additions & 6 deletions pkg/ccl/changefeedccl/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ go_test(
"changefeed_test.go",
"encoder_test.go",
"event_processing_test.go",
"helpers_tenant_shim_test.go",
"helpers_test.go",
"main_test.go",
"name_test.go",
Expand Down Expand Up @@ -173,7 +172,6 @@ go_test(
"//pkg/cloud",
"//pkg/cloud/impl:cloudimpl",
"//pkg/clusterversion",
"//pkg/config",
"//pkg/gossip",
"//pkg/jobs",
"//pkg/jobs/jobspb",
Expand All @@ -182,17 +180,14 @@ go_test(
"//pkg/kv/kvclient/kvcoord",
"//pkg/kv/kvserver",
"//pkg/kv/kvserver/kvserverbase",
"//pkg/kv/kvserver/liveness/livenesspb",
"//pkg/kv/kvserver/protectedts",
"//pkg/kv/kvserver/protectedts/ptpb",
"//pkg/roachpb",
"//pkg/rpc",
"//pkg/security/securityassets",
"//pkg/security/securitytest",
"//pkg/security/username",
"//pkg/server",
"//pkg/server/serverpb",
"//pkg/server/status",
"//pkg/server/telemetry",
"//pkg/settings/cluster",
"//pkg/spanconfig",
Expand Down Expand Up @@ -241,7 +236,6 @@ go_test(
"//pkg/util/randutil",
"//pkg/util/retry",
"//pkg/util/span",
"//pkg/util/stop",
"//pkg/util/syncutil",
"//pkg/util/timeutil",
"//pkg/util/timeutil/pgdate",
Expand Down
Loading

0 comments on commit 24d490e

Please sign in to comment.