Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
103967: build,bazel: upgrade to `rules_js` r=sjbarag a=rickystewart

The library which we were using, `rules_nodejs`, has known deficiencies:

1. The library has been "effectively deprecated" as of the [5.x branch](https://github.com/bazelbuild/rules_nodejs/tree/5.x);
2. the library is incompatible with things we need such as: cross-compilation, Bazel 6.0+, and remote execution;
3. and the library has bugs which we cannot fix, like a race condition which prevents builds from succeeding sporadically, requiring the dev to perform a `clean`.

Here we move to [rules_js](https://github.com/aspect-build/rules_js), the modern alternative.

Epic: none
Release note: None

104820: backupccl: adjust a test to run for secondary tenant codec too r=yuzefovich a=yuzefovich

Fixes: #82882.

Release note: None

104868: roachtest: collect failure artifacts when restore fails r=srosenberg a=renatolabs

This commit updates the `backup-restore/mixed-version` roachtest to
collect artifacts (cockroach logs and a debug.zip) when a restore
fails in the last step of the test (when all backups taken are
restored). In that step, we do not immediately fail the test when a
restore fails but instead attempt to restore every backup and return a
list of errors found when the process is done. However, restoring
cluster backups involves wiping the cluster which also deletes
existing cockroach logs up to that point. This makes debugging a
restore failure that happened prior to a cluster restore impossible.

After this commit, a restore failure in that test will cause a
`restore_failure_N` directory to be created in the artifacts
directory, including the cockroach logs collected right after the
failure, as well as a debug.zip created at the same time.

This will make issues such as #104604 more actionable.

Epic: none

Release note: None

104872: go.mod: bump Pebble to 32834aa62738 r=RaduBerinde a=RaduBerinde

32834aa6 objstorage: support heteorogeneous Storage backends
c75c4d65 db: wrap error when creating Reader with backing filenum
a8a7ebf5 db: Add Option to Filter SSTables

Release note: None
Epic: None

Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Renato Costa <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
  • Loading branch information
5 people committed Jun 14, 2023
5 parents 3441110 + 3d95f5f + a6e57dd + c6403ff + fad2d0e commit 1d3c777
Show file tree
Hide file tree
Showing 65 changed files with 41,881 additions and 1,299 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Input hashes for repository rule npm_translate_lock(name = "npm_e2e_tests", pnpm_lock = "//pkg/ui/workspaces/e2e-tests:pnpm-lock.yaml").
# This file should be checked into version control along with the pnpm-lock.yaml file.
pkg/ui/.npmrc.pnpm=1714720514
pkg/ui/workspaces/e2e-tests/pnpm-lock.yaml=-1787469461
pkg/ui/workspaces/e2e-tests/yarn.lock=226960718
pkg/ui/workspaces/e2e-tests/package.json=1674152024
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Input hashes for repository rule npm_translate_lock(name = "npm_eslint_plugin_crdb", pnpm_lock = "//pkg/ui/workspaces/eslint-plugin-crdb:pnpm-lock.yaml").
# This file should be checked into version control along with the pnpm-lock.yaml file.
pkg/ui/.npmrc.pnpm=1714720514
pkg/ui/workspaces/eslint-plugin-crdb/pnpm-lock.yaml=-541281323
pkg/ui/workspaces/eslint-plugin-crdb/yarn.lock=1024368116
pkg/ui/workspaces/eslint-plugin-crdb/package.json=1575680937
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Input hashes for repository rule npm_translate_lock(name = "npm_cluster_ui", pnpm_lock = "//pkg/ui/workspaces/cluster-ui:pnpm-lock.yaml").
# This file should be checked into version control along with the pnpm-lock.yaml file.
pkg/ui/.npmrc.pnpm=1714720514
pkg/ui/workspaces/cluster-ui/pnpm-lock.yaml=1409758461
pkg/ui/workspaces/cluster-ui/yarn.lock=1601010899
pkg/ui/workspaces/cluster-ui/package.json=991332019
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Input hashes for repository rule npm_translate_lock(name = "npm_protos", pnpm_lock = "//pkg/ui/workspaces/db-console/src/js:pnpm-lock.yaml").
# This file should be checked into version control along with the pnpm-lock.yaml file.
pkg/ui/.npmrc.pnpm=1714720514
pkg/ui/workspaces/db-console/src/js/pnpm-lock.yaml=-1762856267
pkg/ui/workspaces/db-console/src/js/yarn.lock=-452920112
pkg/ui/workspaces/db-console/src/js/package.json=2022600005
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Input hashes for repository rule npm_translate_lock(name = "npm_db_console", pnpm_lock = "//pkg/ui/workspaces/db-console:pnpm-lock.yaml").
# This file should be checked into version control along with the pnpm-lock.yaml file.
pkg/ui/.npmrc.pnpm=1714720514
pkg/ui/workspaces/db-console/pnpm-lock.yaml=307741782
pkg/ui/workspaces/db-console/yarn.lock=1296929611
pkg/ui/workspaces/db-console/package.json=-1415963323
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Input hashes for repository rule npm_translate_lock(name = "npm_mirror_npm", pnpm_lock = "//pkg/cmd/mirror/npm:pnpm-lock.yaml").
# This file should be checked into version control along with the pnpm-lock.yaml file.
pkg/ui/.npmrc.pnpm=1714720514
pkg/cmd/mirror/npm/pnpm-lock.yaml=1846455425
pkg/cmd/mirror/npm/yarn.lock=762706174
pkg/cmd/mirror/npm/package.json=253493674
3 changes: 3 additions & 0 deletions .bazelignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@ artifacts
bin
build/builder_home
lib
pkg/cmd/mirror/npm/node_modules
pkg/ui/node_modules
pkg/ui/workspaces/cluster-ui/node_modules
pkg/ui/workspaces/db-console/node_modules
pkg/ui/workspaces/db-console/src/js/node_modules
pkg/ui/workspaces/e2e-tests/node_modules
pkg/ui/workspaces/eslint-plugin-crdb/node_modules
tmp
vendor
6 changes: 3 additions & 3 deletions DEPS.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -1565,10 +1565,10 @@ def go_deps():
patches = [
"@com_github_cockroachdb_cockroach//build/patches:com_github_cockroachdb_pebble.patch",
],
sha256 = "358d67b4d32db4271e320d0d55066195351ddf97447f93e4ecb9442f3d71949f",
strip_prefix = "github.com/cockroachdb/[email protected]20230612212856-1e8aa51077f0",
sha256 = "e58192b93c07d773152894f78a9b47808a4d90dc1649f53949b0f4eafa58ce2a",
strip_prefix = "github.com/cockroachdb/[email protected]20230614133735-32834aa62738",
urls = [
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230612212856-1e8aa51077f0.zip",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230614133735-32834aa62738.zip",
],
)
go_repository(
Expand Down
Loading

0 comments on commit 1d3c777

Please sign in to comment.