Merge #119506 #119877

119506: ui: add charts on gc assist metric r=lyang24 a=lyang24 This commit adds a line chart contains gc assist duration on the runtime page. The goal is to present the estimated time user go routines spend on assisting gc tasks. Informs: #118875 Release note: None gc assist on crdb single node with kv workload gcttl=5s for database in (kv, system) ![image](https://github.com/cockroachdb/cockroach/assets/20375035/b88882d0-8390-4fe4-8343-eb2a7497bc9f) 119877: roachtest: make pg_regress weekly and its failures non-blocking r=yuzefovich a=yuzefovich This should reduce the amount of toil for us until we iron out most of the differences with postgres. Epic: None Release note: None Co-authored-by: lyang24 <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
cockroachdb · Mar 4, 2024 · 1cab3ba · 1cab3ba
3 parents b5e7608 + 1fca1f6 + 5953d33
commit 1cab3ba
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 8 deletions.
diff --git a/pkg/cmd/roachtest/tests/pg_regress.go b/pkg/cmd/roachtest/tests/pg_regress.go
@@ -460,14 +460,18 @@ func runPGRegress(ctx context.Context, t test.Test, c cluster.Cluster) {
 
 func registerPGRegress(r registry.Registry) {
 	r.Add(registry.TestSpec{
-		Name:             "pg_regress",
-		Owner:            registry.OwnerSQLQueries,
-		Benchmark:        false,
-		Cluster:          r.MakeClusterSpec(1 /* nodeCount */),
-		RequiresLicense:  true,
-		CompatibleClouds: registry.AllExceptAWS,
-		Suites:           registry.Suites(registry.Nightly),
-		Leases:           registry.MetamorphicLeases,
+		Name:      "pg_regress",
+		Owner:     registry.OwnerSQLQueries,
+		Benchmark: false,
+		Cluster:   r.MakeClusterSpec(1 /* nodeCount */),
+		// At the moment, we have a very large deviation from postgres, also
+		// some diffs include line numbers, so we don't treat failures as
+		// blockers for now.
+		NonReleaseBlocker: true,
+		RequiresLicense:   true,
+		CompatibleClouds:  registry.AllExceptAWS,
+		Suites:            registry.Suites(registry.Weekly),
+		Leases:            registry.MetamorphicLeases,
 		Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
 			runPGRegress(ctx, t, c)
 		},

diff --git a/pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/runtime.tsx b/pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/runtime.tsx
@@ -138,6 +138,23 @@ export default function (props: GraphDashboardProps) {
       </Axis>
     </LineGraph>,
 
+    <LineGraph
+      title="GC Assist Time"
+      sources={nodeSources}
+      tenantSource={tenantSource}
+      tooltip={`Estimated total CPU time user goroutines spent performing GC tasks on processors
+        ${tooltipSelection}.`}
+      showMetricsInTooltip={true}
+    >
+      <Axis units={AxisUnits.Duration} label="gc assist time">
+        <Metric
+          name="cr.node.sys.gc.assist.ns"
+          title="GC Assist Time"
+          nonNegativeRate
+        />
+      </Axis>
+    </LineGraph>,
+
     <LineGraph
       title="CPU Time"
       sources={nodeSources}