Merge #93294 #93342

93294: dev: do not log noisy bep flag r=rickystewart a=healthy-pod

Release note: None
Epic: none

93342: sql: partition lease table when optimizing system database for MR r=ajwerner a=ajwerner

This is an oversight from #92588. Testing will come in #92826.

Epic: CRDB-18596

Release note: None

Co-authored-by: healthy-pod <[email protected]>
Co-authored-by: Ahmad Abedalqader <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>

dev

@@ -8,7 +8,7 @@ fi
 set -euo pipefail
 
 # Bump this counter to force rebuilding `dev` on all machines.
-DEV_VERSION=66
+DEV_VERSION=67
 
 THIS_DIR=$(cd "$(dirname "$0")" && pwd)
 BINARY_DIR=$THIS_DIR/bin/dev-versions

pkg/cmd/dev/build.go

@@ -169,12 +169,14 @@ func (d *dev) build(cmd *cobra.Command, commandLine []string) error {
 	args = append(args, additionalBazelArgs...)
 
 	if cross == "" {
+		// Do not log --build_event_binary_file=... because it is not relevant to the actual call
+		// from the user perspective.
+		logCommand("bazel", args...)
 		if buildutil.CrdbTestBuild {
 			args = append(args, "--build_event_binary_file=/tmp/path")
 		} else {
 			args = append(args, fmt.Sprintf("--build_event_binary_file=%s", filepath.Join(tmpDir, bepFileBasename)))
 		}
-		logCommand("bazel", args...)
 		if err := d.exec.CommandContextInheritingStdStreams(ctx, "bazel", args...); err != nil {
 			return err
 		}

pkg/cmd/dev/test.go

@@ -349,14 +349,16 @@ func (d *dev) test(cmd *cobra.Command, commandLine []string) error {
 
 	args = append(args, d.getTestOutputArgs(stress, verbose, showLogs, streamOutput)...)
 	args = append(args, additionalBazelArgs...)
+	logCommand("bazel", args...)
 
+	// Do not log --build_event_binary_file=... because it is not relevant to the actual call
+	// from the user perspective.
 	if buildutil.CrdbTestBuild {
 		args = append(args, "--build_event_binary_file=/tmp/path")
 	} else {
 		args = append(args, fmt.Sprintf("--build_event_binary_file=%s", filepath.Join(tmpDir, bepFileBasename)))
 	}
 
-	logCommand("bazel", args...)
 	err := d.exec.CommandContextInheritingStdStreams(ctx, "bazel", args...)
 	if err != nil {
 		var cmderr *exec.ExitError

pkg/sql/region_util.go

@@ -2470,6 +2470,7 @@ func (p *planner) OptimizeSystemDatabase(ctx context.Context) error {
 	rbrTables := []string{
 		"sqlliveness",
 		"sql_instances",
+		"lease",
 	}
 
 	if !systemschema.TestSupportMultiRegion() {