Skip to content

Commit

Permalink
sql: fix name of constant-hidden SQL string
Browse files Browse the repository at this point in the history
The variable name was implying that the statement was "anonymized" but
that is misleading, since it still contains names and identifiers.

Release justification: low-risk rename
Release note: None
  • Loading branch information
rafiss committed Aug 28, 2021
1 parent 819161b commit 1944c52
Show file tree
Hide file tree
Showing 17 changed files with 528 additions and 525 deletions.
8 changes: 4 additions & 4 deletions docs/generated/http/full.md
Original file line number Diff line number Diff line change
Expand Up @@ -1275,7 +1275,7 @@ Session represents one SQL session.
| alloc_bytes | [int64](#cockroach.server.serverpb.ListSessionsResponse-int64) | | Number of currently allocated bytes in the session memory monitor. | [reserved](#support-status) |
| max_alloc_bytes | [int64](#cockroach.server.serverpb.ListSessionsResponse-int64) | | High water mark of allocated bytes in the session memory monitor. | [reserved](#support-status) |
| active_txn | [TxnInfo](#cockroach.server.serverpb.ListSessionsResponse-cockroach.server.serverpb.TxnInfo) | | Information about the txn in progress on this session. Nil if the session doesn't currently have a transaction. | [reserved](#support-status) |
| last_active_query_anon | [string](#cockroach.server.serverpb.ListSessionsResponse-string) | | The SQL statement fingerprint of the last query executed on this session, compatible with StatementStatisticsKey. | [reserved](#support-status) |
| last_active_query_no_constants | [string](#cockroach.server.serverpb.ListSessionsResponse-string) | | The SQL statement fingerprint of the last query executed on this session, compatible with StatementStatisticsKey. | [reserved](#support-status) |



Expand All @@ -1295,7 +1295,7 @@ ActiveQuery represents a query in flight on some Session.
| is_distributed | [bool](#cockroach.server.serverpb.ListSessionsResponse-bool) | | True if this query is distributed. | [reserved](#support-status) |
| phase | [ActiveQuery.Phase](#cockroach.server.serverpb.ListSessionsResponse-cockroach.server.serverpb.ActiveQuery.Phase) | | phase stores the current phase of execution for this query. | [reserved](#support-status) |
| progress | [float](#cockroach.server.serverpb.ListSessionsResponse-float) | | progress is an estimate of the fraction of this query that has been processed. | [reserved](#support-status) |
| sql_anon | [string](#cockroach.server.serverpb.ListSessionsResponse-string) | | The SQL statement fingerprint, compatible with StatementStatisticsKey. | [reserved](#support-status) |
| sql_no_constants | [string](#cockroach.server.serverpb.ListSessionsResponse-string) | | The SQL statement fingerprint, compatible with StatementStatisticsKey. | [reserved](#support-status) |



Expand Down Expand Up @@ -1403,7 +1403,7 @@ Session represents one SQL session.
| alloc_bytes | [int64](#cockroach.server.serverpb.ListSessionsResponse-int64) | | Number of currently allocated bytes in the session memory monitor. | [reserved](#support-status) |
| max_alloc_bytes | [int64](#cockroach.server.serverpb.ListSessionsResponse-int64) | | High water mark of allocated bytes in the session memory monitor. | [reserved](#support-status) |
| active_txn | [TxnInfo](#cockroach.server.serverpb.ListSessionsResponse-cockroach.server.serverpb.TxnInfo) | | Information about the txn in progress on this session. Nil if the session doesn't currently have a transaction. | [reserved](#support-status) |
| last_active_query_anon | [string](#cockroach.server.serverpb.ListSessionsResponse-string) | | The SQL statement fingerprint of the last query executed on this session, compatible with StatementStatisticsKey. | [reserved](#support-status) |
| last_active_query_no_constants | [string](#cockroach.server.serverpb.ListSessionsResponse-string) | | The SQL statement fingerprint of the last query executed on this session, compatible with StatementStatisticsKey. | [reserved](#support-status) |



Expand All @@ -1423,7 +1423,7 @@ ActiveQuery represents a query in flight on some Session.
| is_distributed | [bool](#cockroach.server.serverpb.ListSessionsResponse-bool) | | True if this query is distributed. | [reserved](#support-status) |
| phase | [ActiveQuery.Phase](#cockroach.server.serverpb.ListSessionsResponse-cockroach.server.serverpb.ActiveQuery.Phase) | | phase stores the current phase of execution for this query. | [reserved](#support-status) |
| progress | [float](#cockroach.server.serverpb.ListSessionsResponse-float) | | progress is an estimate of the fraction of this query that has been processed. | [reserved](#support-status) |
| sql_anon | [string](#cockroach.server.serverpb.ListSessionsResponse-string) | | The SQL statement fingerprint, compatible with StatementStatisticsKey. | [reserved](#support-status) |
| sql_no_constants | [string](#cockroach.server.serverpb.ListSessionsResponse-string) | | The SQL statement fingerprint, compatible with StatementStatisticsKey. | [reserved](#support-status) |



Expand Down
8 changes: 4 additions & 4 deletions docs/generated/swagger/spec.json
Original file line number Diff line number Diff line change
Expand Up @@ -618,10 +618,10 @@
"type": "string",
"x-go-name": "Sql"
},
"sql_anon": {
"sql_no_constants": {
"description": "The SQL statement fingerprint, compatible with StatementStatisticsKey.",
"type": "string",
"x-go-name": "SqlAnon"
"x-go-name": "SqlNoConstants"
},
"start": {
"description": "Start timestamp of this query.",
Expand Down Expand Up @@ -1088,10 +1088,10 @@
"type": "string",
"x-go-name": "LastActiveQuery"
},
"last_active_query_anon": {
"last_active_query_no_constants": {
"description": "The SQL statement fingerprint of the last query executed on this session,\ncompatible with StatementStatisticsKey.",
"type": "string",
"x-go-name": "LastActiveQueryAnon"
"x-go-name": "LastActiveQueryNoConstants"
},
"max_alloc_bytes": {
"description": "High water mark of allocated bytes in the session memory monitor.",
Expand Down
Loading

0 comments on commit 1944c52

Please sign in to comment.