UI: add "rocksdb.estimate-table-readers-mem" to graphs.

This metric increases with the number of keys in rocksdb and can become a sizeable chunk of the allocated memory (eg: ~50% of cgo memory in the beta cluster)
cockroachdb · Jun 15, 2016 · 15bd139 · 15bd139
1 parent dfe2d0c
commit 15bd139
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/ui/embedded.go b/ui/embedded.go
diff --git a/ui/next/app/containers/nodeGraphs.tsx b/ui/next/app/containers/nodeGraphs.tsx
@@ -150,6 +150,7 @@ export default class extends React.Component<RouteComponentProps<any, any>, {}>
                 <Metric name="cr.store.rocksdb.block.cache.usage" title="Block Cache" />
                 <Metric name="cr.store.rocksdb.block.cache.pinned-usage" title="Iterators" />
                 <Metric name="cr.store.rocksdb.memtable.total-size" title="Memtable" />
+                <Metric name="cr.store.rocksdb.table-readers-mem-estimate" title="Index" />
               </Axis>
             </LineGraph>
 

diff --git a/ui/next/app/containers/nodesGraphs.tsx b/ui/next/app/containers/nodesGraphs.tsx
@@ -145,6 +145,7 @@ export default class extends React.Component<{}, {}> {
                 <Metric name="cr.store.rocksdb.block.cache.usage" title="Block Cache" />
                 <Metric name="cr.store.rocksdb.block.cache.pinned-usage" title="Iterators" />
                 <Metric name="cr.store.rocksdb.memtable.total-size" title="Memtable" />
+                <Metric name="cr.store.rocksdb.table-readers-mem-estimate" title="Index" />
               </Axis>
             </LineGraph>
 

diff --git a/ui/ts/pages/nodes.ts b/ui/ts/pages/nodes.ts
@@ -407,7 +407,9 @@ module AdminViews {
               Metrics.Select.Avg(_storeMetric("rocksdb.block.cache.pinned-usage"))
                 .title("Iterators"),
               Metrics.Select.Avg(_storeMetric("rocksdb.memtable.total-size"))
-                .title("Memtable")
+                .title("Memtable"),
+              Metrics.Select.Avg(_storeMetric("rocksdb.table-readers-mem-estimate"))
+                .title("Index")
             ).format(Utils.Format.Bytes).title("Engine Memory Usage")
           );
           this._addChart(
@@ -1008,7 +1010,10 @@ module AdminViews {
                 .title("Iterators"),
               Metrics.Select.Avg(_storeMetric("rocksdb.memtable.total-size"))
                 .sources(this._storeIds)
-                .title("Memtable")
+                .title("Memtable"),
+              Metrics.Select.Avg(_storeMetric("rocksdb.table-readers-mem-estimate"))
+                .sources(this._storeIds)
+                .title("Index")
             ).format(Utils.Format.Bytes).title("Engine Memory Usage")
           );
           this._addChart(