Skip to content

Commit

Permalink
Merge pull request #130752 from cockroachdb/blathers/backport-release…
Browse files Browse the repository at this point in the history
…-24.2.3-rc-130709

release-24.2.3-rc: util: publish cidr metrics for tenants
  • Loading branch information
andrewbaptist authored Sep 16, 2024
2 parents 7af0732 + 95cb339 commit 131d183
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pkg/server/tenant.go
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,13 @@ func newTenantServer(
}
}

// NB: On a shared process tenant, we start cidr once per tenant.
// Potentially we could share this across tenants, but this breaks the
// tenant separation model. For a small number of tenants this is OK, but if
// we have a large number of tenants in shared process mode this could be a
// problem from a memory and network perspective.
baseCfg.CidrLookup.Start(ctx, stopper)

// Instantiate the SQL server proper.
sqlServer, err := newSQLServer(ctx, args)
if err != nil {
Expand Down

0 comments on commit 131d183

Please sign in to comment.