roachprod: add env var for secure default

Release note: none. Epic: none.
cockroachdb · May 10, 2024 · 11edce0 · 11edce0
1 parent d9689c8
commit 11edce0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pkg/cmd/roachprod/BUILD.bazel b/pkg/cmd/roachprod/BUILD.bazel
@@ -22,6 +22,7 @@ go_library(
         "//pkg/roachprod/ui",
         "//pkg/roachprod/vm",
         "//pkg/roachprod/vm/gce",
+        "//pkg/util/envutil",
         "//pkg/util/flagutil",
         "//pkg/util/timeutil",
         "@com_github_cockroachdb_errors//:errors",

diff --git a/pkg/cmd/roachprod/flags.go b/pkg/cmd/roachprod/flags.go
@@ -22,6 +22,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/roachprod/ssh"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/vm"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/vm/gce"
+	"github.com/cockroachdb/cockroach/pkg/util/envutil"
 	"github.com/cockroachdb/cockroach/pkg/util/flagutil"
 	"github.com/spf13/cobra"
 	"golang.org/x/exp/maps"
@@ -50,7 +51,7 @@ var (
 	listPattern           string
 	isSecure              bool   // Set based on the values passed to --secure and --insecure
 	secure                = true // DEPRECATED
-	insecure              = false
+	insecure              = envutil.EnvOrDefaultBool("COCKROACH_ROACHPROD_INSECURE", false)
 	virtualClusterName    string
 	sqlInstance           int
 	extraSSHOptions       = ""