Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
backupccl: possibly deflake TestBackupRestoreAppend
In CI we've seen this test fail with: backup_test.go:670: error scanning '&{<nil> 0xc019c5b580}': pq: restart transaction: TransactionRetryWithProtoRefreshError: TransactionRetryError: retry txn (RETRY_SERIALIZABLE - failed preemptive refresh): "sql txn" meta={id=77054b51 key=/Table/121/1 pri=0.03587869 epo=0 ts=1689916873.568949604,1 min=1689916873.436580640,0 seq=1000} lock=true stat=PENDING rts=1689916873.436580640,0 wto=false gul=1689916873.936580640,0 The `RETURNING` clauses on these two `UPDATE` statements prevent automatic transaction retries. Here we wrap the queries in an explicit transaction with a retry loop which should prevent the test failure test, assuming that the update isn't so contended it won't ever complete. I am unable to stress this enough locally to reproduce this error. Probably Fixes #107330 Epic: none Release note: None
- Loading branch information