Skip to content

Commit

Permalink
cluster: relax the instructions for deleting versions
Browse files Browse the repository at this point in the history
The instructions used to suggest that you can't delete a version
constant, but I think that was misguided. I believe you can generally
delete them just fine (except perhaps the highest one at the deletion
time).

Release note: None
  • Loading branch information
andreimatei committed Jan 10, 2019
1 parent 10496df commit 10a7dd3
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions pkg/settings/cluster/cockroach_versions.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@ type VersionKey int
//
// To delete a version.
// - Remove its associated runtime checks.
// - Mark it as "unused" when it is only referenced in this file.
// - If the version key after a major or minor version is unused, remove it
// and its associated keyedVersion.
// - Apply recursively.
// - If the version is not the latest one, delete the constant and comment out
// its stanza and say "deleted" in the versionsSingleton.
const (
VersionBase VersionKey = iota
VersionRaftLogTruncationBelowRaft
Expand Down

0 comments on commit 10a7dd3

Please sign in to comment.