Skip to content

Commit

Permalink
roachtest: verbose gRPC logging for admission-control/tpcc-olap
Browse files Browse the repository at this point in the history
I ran the test[^1] and it passed, so hopefully this isn't obviously breaking
anything.

See #96543.

[^1]: `GCE_PROJECT=andrei-jepsen ./pkg/cmd/roachtest/roachstress.sh -c 1 -u admission-control/tpcc-olap/nodes=3/cpu=8/w=50/c=96 -- tag:weekly`

Epic: none
Release note: None
  • Loading branch information
tbg committed Feb 8, 2023
1 parent cc99062 commit 0f08f6d
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions pkg/cmd/roachtest/tests/admission_control_tpcc_overload.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,28 @@ func (s tpccOLAPSpec) run(ctx context.Context, t test.Test, c cluster.Cluster) {
return nil
})
m.Wait()

// Before checking liveness, set the gRPC logging[^1] to verbose. We stopped the
// load so this should be OK in terms of overhead, and it can explain to us why
// we see gRPC connections buckle in this workload. See:
//
// https://github.com/cockroachdb/cockroach/issues/96543
//
// [^1]: google.golang.org/grpc/grpclog/component.go
for i := 1; i <= c.Spec().NodeCount-1; i++ {
_, err := c.Conn(ctx, t.L(), i).ExecContext(ctx, `SELECT crdb_internal.set_vmodule('component=2');`)
if err != nil {
t.L().PrintfCtx(ctx, "ignoring vmodule error: %s", err)
}
}
defer func() {
for i := 1; i <= c.Spec().NodeCount-1; i++ {
_, err := c.Conn(ctx, t.L(), i).ExecContext(ctx, `SELECT crdb_internal.set_vmodule('');`)
if err != nil {
t.L().PrintfCtx(ctx, "ignoring vmodule-reset error: %s", err)
}
}
}()
verifyNodeLiveness(ctx, c, t, duration)
}

Expand Down

0 comments on commit 0f08f6d

Please sign in to comment.