Skip to content

Commit

Permalink
sql: support no-op CREATE EXTENSION pg_trgm
Browse files Browse the repository at this point in the history
Release note: None
  • Loading branch information
jordanlewis committed May 6, 2022
1 parent a9404c6 commit 0d1bcd9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions pkg/sql/create_extension.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ func (n *createExtensionNode) unimplementedExtensionError(issue int) error {
func (n *createExtensionNode) startExec(params runParams) error {
switch n.CreateExtension.Name {
case "postgis",
"pg_trgm",
"uuid-ossp":
telemetry.Inc(sqltelemetry.CreateExtensionCounter(n.CreateExtension.Name))
return nil
Expand All @@ -64,8 +65,6 @@ func (n *createExtensionNode) startExec(params runParams) error {
return n.unimplementedExtensionError(41276)
case "postgres_fdw":
return n.unimplementedExtensionError(20249)
case "pg_trgm":
return n.unimplementedExtensionError(51137)
case "adminpack",
"amcheck",
"auth_delay",
Expand Down
3 changes: 1 addition & 2 deletions pkg/sql/testdata/telemetry/extension
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ unimplemented.#54514.CREATE EXTENSION postgis_raster
feature-usage
CREATE EXTENSION pg_trgm
----
error: pq: unimplemented: extension "pg_trgm" is not yet supported
unimplemented.#51137.CREATE EXTENSION pg_trgm
sql.extension.create.pg_trgm

feature-usage
CREATE EXTENSION xml2
Expand Down

0 comments on commit 0d1bcd9

Please sign in to comment.