Skip to content

Commit

Permalink
kvserver: skip promote non voter under race
Browse files Browse the repository at this point in the history
TestPromoteNonVoterInAddVoter requires that the initial range count of
each store is balanced. Under stress/race builds this takes much longer
and may time out before achieved.

TestPromoteNonVoterInAddVoter was already skipped under stress, also
skip the test under race.

Resolves: #105883

Release note: None
  • Loading branch information
kvoli committed Jul 11, 2023
1 parent c3a0838 commit 077db91
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/kv/kvserver/replicate_queue_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2211,10 +2211,11 @@ func TestPromoteNonVoterInAddVoter(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

// This test is slow under stress and can time out when upreplicating /
// This test is slow under stress/race and can time out when upreplicating /
// rebalancing to ensure all stores have the same range count initially, due
// to slow heartbeats.
skip.UnderStress(t)
skip.UnderRace(t)

ctx := context.Background()

Expand Down

0 comments on commit 077db91

Please sign in to comment.