Skip to content

Commit

Permalink
Merge #28249
Browse files Browse the repository at this point in the history
28249: cli: allow `node status` to work in unavailable/broken clusters r=bdarnell a=petermattis

Expand the `crdb_internal.gossip_liveness` table to include columns
needed to satisfy the basic usage of `node status`. Specifically, added
`address`, `build`, `started_at`, `updated_at` and `replicas`
columns. Changed `node status` to use `gossip_liveness` instead of
`kv_node_status`. The latter table requires the range containing the
consistent node status descriptors to be available, while
`gossip_liveness` only retrieves info from gossip.

`node status` and `node status --decommission` will work on
unavailable/broken clusters as long as the node they are pointed to is
up. `node status {--stats,--ranges,--all}` continue to require a
reasonably healthy cluster.

Fixes #16489

Release note (cli change): Enhance `node status` to work on
unavailable/broken clusters.

Co-authored-by: Peter Mattis <[email protected]>
  • Loading branch information
craig[bot] and petermattis committed Aug 10, 2018
2 parents 06e1b4e + bf33234 commit 0757925
Show file tree
Hide file tree
Showing 14 changed files with 548 additions and 136 deletions.
6 changes: 2 additions & 4 deletions build/teamcity-local-roachtest.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,8 @@ run build/builder.sh make bin/workload bin/roachtest
tc_end_block "Compile workload/roachtest"

tc_start_block "Run local roachtests"
# TODO(dan): Run kv/splits as a proof of concept of running roachtest on every
# PR. After we're sure this is stable, curate a suite of the tests that work
# locally.
run build/builder.sh ./bin/roachtest run kv/splits \
# TODO(peter,dan): curate a suite of the tests that works locally.
run build/builder.sh ./bin/roachtest run '(cli|kv/splits)' \
--local \
--cockroach "cockroach" \
--workload "bin/workload" \
Expand Down
106 changes: 89 additions & 17 deletions c-deps/libroach/protos/roachpb/metadata.pb.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 0757925

Please sign in to comment.