parser: fix string repr of ALTER ... START REPLICATION

Release note: none. Epic: none.
cockroachdb · Jan 16, 2024 · 067a73a · 067a73a
1 parent 515663b
commit 067a73a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/pkg/sql/parser/testdata/alter_virtual_cluster b/pkg/sql/parser/testdata/alter_virtual_cluster
@@ -258,10 +258,10 @@ ALTER VIRTUAL CLUSTER 'foo' SET REPLICATION RETENTION = '-2h' -- identifiers rem
 parse
 ALTER TENANT 'foo' START REPLICATION OF 'bar' ON 'baz' WITH RETENTION = '-1h'
 ----
-ALTER VIRTUAL CLUSTER 'foo' SET REPLICATION RETENTION = '-1h' -- normalized!
-ALTER VIRTUAL CLUSTER ('foo') SET REPLICATION RETENTION = ('-1h') -- fully parenthesized
-ALTER VIRTUAL CLUSTER '_' SET REPLICATION RETENTION = '_' -- literals removed
-ALTER VIRTUAL CLUSTER 'foo' SET REPLICATION RETENTION = '-1h' -- identifiers removed
+ALTER VIRTUAL CLUSTER 'foo' START REPLICATION OF 'bar' ON 'baz' WITH RETENTION = '-1h' -- normalized!
+ALTER VIRTUAL CLUSTER ('foo') START REPLICATION OF ('bar') ON ('baz') WITH RETENTION = ('-1h') -- fully parenthesized
+ALTER VIRTUAL CLUSTER '_' START REPLICATION OF '_' ON '_' WITH RETENTION = '_' -- literals removed
+ALTER VIRTUAL CLUSTER 'foo' START REPLICATION OF 'bar' ON 'baz' WITH RETENTION = '-1h' -- identifiers removed
 
 parse
 ALTER VIRTUAL CLUSTER 'foo' SET REPLICATION EXPIRATION WINDOW = '2h'

diff --git a/pkg/sql/sem/tree/alter_tenant.go b/pkg/sql/sem/tree/alter_tenant.go
@@ -44,12 +44,6 @@ func (n *AlterTenantReplication) Format(ctx *FmtCtx) {
 			ctx.WriteString("SYSTEM TIME ")
 			ctx.FormatNode(n.Cutover.Timestamp)
 		}
-	} else if !n.Options.IsDefault() {
-		ctx.WriteString("SET REPLICATION ")
-		ctx.FormatNode(&n.Options)
-	} else if n.Command == PauseJob || n.Command == ResumeJob {
-		ctx.WriteString(JobCommandToStatement[n.Command])
-		ctx.WriteString(" REPLICATION")
 	} else if n.ReplicationSourceTenantName != nil {
 		ctx.WriteString("START REPLICATION OF ")
 		ctx.FormatNode(n.ReplicationSourceTenantName)
@@ -67,6 +61,12 @@ func (n *AlterTenantReplication) Format(ctx *FmtCtx) {
 			ctx.WriteString(" WITH ")
 			ctx.FormatNode(&n.Options)
 		}
+	} else if !n.Options.IsDefault() {
+		ctx.WriteString("SET REPLICATION ")
+		ctx.FormatNode(&n.Options)
+	} else if n.Command == PauseJob || n.Command == ResumeJob {
+		ctx.WriteString(JobCommandToStatement[n.Command])
+		ctx.WriteString(" REPLICATION")
 	}
 }