Skip to content

Commit

Permalink
Merge pull request #63872 from miretskiy/backport20.2-63857
Browse files Browse the repository at this point in the history
release-20.2: changefeedccl: Make `kafka_sink_config` a valid option.
  • Loading branch information
miretskiy authored Apr 20, 2021
2 parents 2de84b0 + 3e93c28 commit 041b395
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/ccl/changefeedccl/changefeed_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2083,7 +2083,10 @@ func TestChangefeedErrors(t *testing.T) {
t, `sasl_enabled must be enabled if a SASL password is provided`,
`CREATE CHANGEFEED FOR foo INTO $1`, `kafka://nope/?sasl_password=a`,
)

sqlDB.ExpectErr(
t, `client has run out of available brokers`,
`CREATE CHANGEFEED FOR foo INTO 'kafka://nope/' WITH kafka_sink_config='{"Flush": {"Messages": 100}}'`,
)
// The avro format doesn't support key_in_value yet.
sqlDB.ExpectErr(
t, `key_in_value is not supported with format=experimental_avro`,
Expand Down
1 change: 1 addition & 0 deletions pkg/ccl/changefeedccl/changefeedbase/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,4 +113,5 @@ var ChangefeedOptionExpectValues = map[string]sql.KVStringOptValidate{
OptInitialScan: sql.KVStringOptRequireNoValue,
OptNoInitialScan: sql.KVStringOptRequireNoValue,
OptProtectDataFromGCOnPause: sql.KVStringOptRequireNoValue,
OptKafkaSinkConfig: sql.KVStringOptRequireValue,
}

0 comments on commit 041b395

Please sign in to comment.