Merge #89069

89069: admission: decrease log chattiness r=irfansharif a=knz The "CPULoad switching to period" was the 9th most voluminous log event source in CC. This commit reduces its verbosity. Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]>
cockroachdb · Sep 30, 2022 · 02b01c9 · 02b01c9
2 parents 857c7e0 + 3cfc79f
commit 02b01c9
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/util/admission/grant_coordinator.go b/pkg/util/admission/grant_coordinator.go
@@ -657,9 +657,11 @@ func (coord *GrantCoordinator) GetWorkQueue(workKind WorkKind) *WorkQueue {
 func (coord *GrantCoordinator) CPULoad(runnable int, procs int, samplePeriod time.Duration) {
 	ctx := coord.ambientCtx.AnnotateCtx(context.Background())
 
-	if coord.lastCPULoadSamplePeriod != 0 && coord.lastCPULoadSamplePeriod != samplePeriod &&
-		KVAdmissionControlEnabled.Get(&coord.settings.SV) {
-		log.Infof(ctx, "CPULoad switching to period %s", samplePeriod.String())
+	if log.V(1) {
+		if coord.lastCPULoadSamplePeriod != 0 && coord.lastCPULoadSamplePeriod != samplePeriod &&
+			KVAdmissionControlEnabled.Get(&coord.settings.SV) {
+			log.Infof(ctx, "CPULoad switching to period %s", samplePeriod.String())
+		}
 	}
 	coord.lastCPULoadSamplePeriod = samplePeriod