Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update code #151

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Add update code #151

merged 3 commits into from
Sep 1, 2020

Conversation

chrisseto
Copy link
Contributor

Looks like some extra go.mod changes snuck in? Uncertain if that's a problem

@chrisseto chrisseto requested a review from chrislovecnm August 24, 2020 18:57
@chrislovecnm
Copy link
Contributor

CI failed

hack/build/repos.bzl Outdated Show resolved Hide resolved
@chrislovecnm
Copy link
Contributor

Looks like some extra go.mod changes snuck in? Uncertain if that's a problem

This is fixed. We had the wrong version of semver imported. And I included some code from the k8s codebase. Having 20 lines of new code is better than importing all of k8s. Probably should move it into its own code file though.

@chrislovecnm chrislovecnm force-pushed the upgrade-code branch 2 times, most recently from 12b915f to 09ee0dd Compare September 1, 2020 13:35
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrislovecnm chrislovecnm merged commit 9e4ced6 into master Sep 1, 2020
@udnay udnay deleted the upgrade-code branch June 26, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants