testserver: no longer rely on auto-init #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cockroach start` without `--join` is deprecated behavior, and something we're looking to get rid of in cockroachdb/cockroach#51245.
|
This change is |
|
Thanks! |
irfansharif
added a commit
to cockroachdb/examples-orms
that referenced
this pull request
Jul 10, 2020
irfansharif
added a commit
to cockroachdb/examples-orms
that referenced
this pull request
Jul 10, 2020
Picks up cockroachdb/cockroach-go#81. Cleans up test code along the way to work with latest cockroach-go (testserver.NewTestServer already starts the server it seems, there's no need to start it again).
irfansharif
added a commit
to cockroachdb/examples-orms
that referenced
this pull request
Jul 14, 2020
Picks up cockroachdb/cockroach-go#81. Cleans up test code along the way to work with latest cockroach-go (testserver.NewTestServer already starts the server it seems, there's no need to start it again).
irfansharif
added a commit
to cockroachdb/examples-orms
that referenced
this pull request
Jul 14, 2020
Picks up cockroachdb/cockroach-go#81. Cleans up test code along the way to work with latest cockroach-go (testserver.NewTestServer already starts the server it seems, there's no need to start it again).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cockroach startwithout--joinis deprecated behavior, and somethingwe're looking to get rid of in cockroachdb/cockroach#51245.