testserver: look for sql url on stderr #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of CockroachDB prints the SQL url on stderr instead of stdout when --logtostderr is specified.
tamird
approved these changes
May 3, 2017
|
The change here comes from cockroachdb/cockroach#15597 The complaint (from Alex, Andrei) was that the node startup message with this info was printed both on stdout and stderr when --logtostderr is enabled. The reasoning behind was that 1) the startup message must be copied to the logs always (for later investigation) and 2) for consistency it would be strange to have different logging output depending on whether --logtostderr is set So I decided to not place it to stdout any more, but now your issue highlights that this may have been the wrong call -- perhaps stdout is the right place after all? |
benesch
added a commit
that referenced
this pull request
May 3, 2017
Use the new `--listening-url-file` flag to specify a file in which the SQL URL will be written. This flag was added in cockroachdb/cockroach#15468 for exactly this purpose, and makes this testserver resilient to changes in what log output is printed where. Closes #29.
|
I found a better way; submitted as #30. |
benesch
added a commit
that referenced
this pull request
May 3, 2017
Use the new `--listening-url-file` flag to specify a file in which the SQL URL will be written. This flag was added in cockroachdb/cockroach#15468 for exactly this purpose, and makes this testserver resilient to changes in what log output is printed where. Closes #29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of CockroachDB prints the SQL url on stderr instead of stdout when
--logtostderris specified.@knz, I know you've been working on the logging recently. Let me know if this change wasn't intentional (i.e., if the SQL url should still be printed on stdout when
--logtostderris passed).This change is