testserver: introduce CockroachLogsDirOpt #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This new parameter allows callers to specify a root directory where logs for cockroach processes created by testserver will be located. Previously, when calling `testserver.Stop()`, *all* resources would be deleted, including cockroach logs. By allowing the caller to specify a custom directory, we allow the possibility for the logs to outlive the cockroach processes, which is especially useful when debugging test failures.
renatolabs
force-pushed
the
cockroach-logs-dir
branch
from
783cedc to
68fede3
Compare
rafiss
approved these changes
Jun 3, 2023
renatolabs
added a commit
to renatolabs/cockroach
that referenced
this pull request
Jun 14, 2023
This commit makes use of the new `CockroachLogsDirOpt` option introduced in [1] to pass a custom directory where cockroach logs will be stored. This directory is relative to TMPDIR, which is part of the artifacts path when the test runs in CI. With this change, when a logic test using the cockroach-go config fails, we'll be able to see both the test logs as well as the cockroach logs themselves. The latter will be in the `cockroach.stderr` file. [1] cockroachdb/cockroach-go#170 Epic: none Release note: None
renatolabs
added a commit
to renatolabs/cockroach
that referenced
this pull request
Jun 14, 2023
This commit makes use of the new `CockroachLogsDirOpt` option introduced in [1] to pass a custom directory where cockroach logs will be stored. This directory is relative to TMPDIR, which is part of the artifacts path when the test runs in CI. With this change, when a logic test using the cockroach-go config fails, we'll be able to see both the test logs as well as the cockroach logs themselves. The latter will be in the `cockroach.stderr` file. [1] cockroachdb/cockroach-go#170 Epic: none Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Jun 14, 2023
104821: upgrade: checkpoint fence version for multi-tenant clusters r=JeffSwenson a=JeffSwenson Previously, the tenant upgrade interlock checkpointed the version attached to the upgrade, when it should have checkpointed the fence version. This made it possible for an upgrade to skip versions. The conditions needed for this are rare, but could be triggered by crashes in the upgrade system or by the autoscaler downscaling a serverless cluster with multiple nodes. Release Note: None Fixes: #104884 104876: logic: keep cockroach-go logs in case of failure r=rafiss a=renatolabs This commit makes use of the new `CockroachLogsDirOpt` option introduced in [1] to pass a custom directory where cockroach logs will be stored. This directory is relative to TMPDIR, which is part of the artifacts path when the test runs in CI. With this change, when a logic test using the cockroach-go config fails, we'll be able to see both the test logs as well as the cockroach logs themselves. The latter will be in the `cockroach.stderr` file. [1] cockroachdb/cockroach-go#170 Epic: none Release note: None 104879: upgrades: deflake TestBackfillJobsInfoTable r=stevendanna a=adityamaru Previously, this test created jobs that could be adopted during test execution causing the number of payload/progress updates to be variable. With this change we create startable jobs so that they are not adopted and the number of payload/progress remain constant. Fixes: #103046 Release note: None Co-authored-by: Jeff <[email protected]> Co-authored-by: Renato Costa <[email protected]> Co-authored-by: adityamaru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new parameter allows callers to specify a root directory where logs for cockroach processes created by testserver will be located.
Previously, when calling
testserver.Stop(), all resources would be deleted, including cockroach logs. By allowing the caller to specify a custom directory, we allow the possibility for the logs to outlive the cockroach processes, which is especially useful when debugging test failures.