Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apd: add Size method #97

Closed
wants to merge 1 commit into from
Closed

apd: add Size method #97

wants to merge 1 commit into from

Conversation

yuzefovich
Copy link
Member

No description provided.

@yuzefovich yuzefovich requested a review from asubiotto October 8, 2020 20:48
@asubiotto
Copy link

It doesn't feel like this is something that apd should provide. We already have a SizeOfDecimal function in pkg/sql/sem/tree/datum.go, is that not what you need?

@yuzefovich
Copy link
Member Author

Oh, indeed, I don't why I didn't check that myself.

@yuzefovich yuzefovich closed this Oct 12, 2020
@yuzefovich yuzefovich deleted the size branch October 12, 2020 16:04
nvanbenschoten added a commit to nvanbenschoten/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvanbenschoten added a commit to nvanbenschoten/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvanbenschoten added a commit to nvanbenschoten/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvanbenschoten added a commit to nvanbenschoten/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvanbenschoten added a commit to nvanbenschoten/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvanbenschoten added a commit to nvanbenschoten/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvanbenschoten added a commit to nvanbenschoten/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants