Move to PatternFly Elements and lit #1028
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This comment was marked as resolved.
This comment was marked as resolved.
martinpitt
force-pushed
the
pf-elements
branch
from
f8befc8 to
7ecaca0
Compare
|
curious how this might affect final bundle sizes, page loading speed, and runtime performance |
|
@bennypowers bundle sizes are in the description. I didn't test performance, for starter-kit everything is so fast that it makes no practical difference. |
martinpitt
force-pushed
the
pf-elements
branch
2 times, most recently
from
814f586 to
03f5e4e
Compare
martinpitt
force-pushed
the
pf-elements
branch
from
4ad1525 to
c106104
Compare
This comment was marked as resolved.
This comment was marked as resolved.
martinpitt
force-pushed
the
pf-elements
branch
from
c106104 to
467d79d
Compare
bennypowers
reviewed
Nov 12, 2024
bennypowers
reviewed
Nov 12, 2024
bennypowers
reviewed
Nov 12, 2024
bennypowers
reviewed
Nov 12, 2024
|
תודה לך! I applied your suggestions. |
martinpitt
force-pushed
the
pf-elements
branch
2 times, most recently
from
b111b56 to
94bb2f4
Compare
|
Got rid of |
martinpitt
force-pushed
the
pf-elements
branch
2 times, most recently
from
d137e0a to
1c6f884
Compare
PFE uses lit, so it makes sense to just use that for the main application as well. Web components are pretty much React built into the web platform, and lit adds some convenience around that. This is mostly a demo -- for real Cockpit pages, PF Elements is still missing too many components.
martinpitt
force-pushed
the
pf-elements
branch
from
1c6f884 to
5aa2020
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PFE uses lit, so it makes sense to just use that for the main
application as well. Web components are pretty much React built into the
web platform, and lit adds some convenience around that.
This is mostly a demo -- for real Cockpit pages, PF Elements is still
missing too many components.
This is part of my Day of Learning -- I don't think we should just land that. Perhaps we want to keep it in a branch, or a separate starter-kit-pfe project, I don't know yet. For now this is just a demo.
The size difference is quite impressive:
The UI isn't surprising:
But this changed the
<Alert>to a normal<p>, as PF Elements does not have an alert yet: patternfly/patternfly-elements#2539