packit: Enable tests on Fedora Rawhide, systemd: Cancel shutdown as root #17302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should be treated as advisory, but they will help us to spot issues like https://bugzilla.redhat.com/show_bug.cgi?id=2081039
martinpitt
added
the
no-test
|
I will add the fix next, but I first want to double-check that this spots the issue. |
|
Yup, that exactly reproduces the bug. |
systemd 251 started to guard this as a privileged operation with polkit [1]. So call this as root if possible. This is an incomplete fix: We should not even show the cancel action if the session is not root and not allowed via a polkit rule, but that is more intrusive -- let's fix the exploding gating test first. https://bugzilla.redhat.com/show_bug.cgi?id=2081039 [1] systemd/systemd@ec14fba91c94f38f3
martinpitt
changed the title
martinpitt
removed
the
no-test
|
I filed issue #17325 for the refinement. |
|
@jelly : As this is a blocker for tomorrow's release, friendly review reminder? Thanks! |
jelly
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should be treated as advisory, but they will help us to spot
issues like https://bugzilla.redhat.com/show_bug.cgi?id=2081039
systemd 251 started to guard this as a privileged operation with polkit [1].
So call this as root if possible.
This is an incomplete fix: We should not even show the cancel action if
the session is not root and not allowed via a polkit rule, but that is
more intrusive -- let's fix the exploding gating test first.
https://bugzilla.redhat.com/show_bug.cgi?id=2081039
[1] systemd/systemd@ec14fba91c94f38f3